[C&P] Fix Unbonding slashed suppliers #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
added
bug
okdas
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Thank you SO MUCH! ❤️
Once this is merged, I'll try to do more load testing shortly to see if we can break the network again.
I'll wait for more input from @Olshansk or @bryanchriswhite — I'm not comfortable signing for such changes yet. 😅
| @@ -273,8 +273,10 @@ func (st *sessionTree) Delete() error { | |||
| // This was intentionally removed to lower the IO load. | |||
| // When the database is closed, it is deleted it from disk right away. | |||
|
|
|||
| if err := st.treeStore.Stop(); err != nil { | |||
| return err | |||
| if st.treeStore != nil { | |||
There was a problem hiding this comment.
Can we add an error log if treeStore == nil?
I think it would be helpful if this condition is reached for whatever reason in the future.
bryanchriswhite
approved these changes
Oct 23, 2024
Olshansk
approved these changes
Oct 23, 2024
| @@ -273,8 +273,10 @@ func (st *sessionTree) Delete() error { | |||
| // This was intentionally removed to lower the IO load. | |||
| // When the database is closed, it is deleted it from disk right away. | |||
|
|
|||
| if err := st.treeStore.Stop(); err != nil { | |||
| return err | |||
| if st.treeStore != nil { | |||
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 891) |
github-actions
bot
added
devnet
push-image
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary This PR fixes a few bugs that were dependent to each other: 1. Gracefully unbond suppliers that have 0upokt due to off-stake slashing. 2. Fix access to an expired session tree on the realy miner 3. Fix proof block hash seed used on chain. @okdas , One case I didn't manage to reproduce is having the application module account go to `0`. Please tell me if you encounter it again. ## Issue - #841 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [x] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a few bugs that were dependent to each other:
@okdas , One case I didn't manage to reproduce is having the application module account go to
0. Please tell me if you encounter it again.Issue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist